Skip to content

layout: Properly set IS_BLEND_CONTAINER when creating WebRender stacking contexts#60589

Open
servo-wpt-sync wants to merge 1 commit into
web-platform-tests:masterfrom
servo:servo_export_45624
Open

layout: Properly set IS_BLEND_CONTAINER when creating WebRender stacking contexts#60589
servo-wpt-sync wants to merge 1 commit into
web-platform-tests:masterfrom
servo:servo_export_45624

Conversation

@servo-wpt-sync

Copy link
Copy Markdown
Collaborator

In order to properly support mix-blend-mode stacking contexts that are
parents of child stacking contexts with mix-blend-mode in their style
need to be marked with the is IS_BLEND_CONTAINER StackingContextFlag.
In addition to correcting the display of mix-blend-mode content, this
also work around an issue where mix-blend-mode was causing a panic
when combined with a particular transform.

This also works around a variety of WebRender bugs that happen when
mix-blend-mode is used near the root stacking context.

Testing: This change updates test results and also adds a WPT crash test.
Fixes: #42292.

Reviewed in servo/servo#45624

…ing contexts

In order to properly support `mix-blend-mode` stacking contexts that are
parents of child stacking contexts with `mix-blend-mode` in their style
need to be marked with the is `IS_BLEND_CONTAINER` StackingContextFlag.
In addition to correcting the display of `mix-blend-mode` content, this
also work around an issue where `mix-blend-mode` was causing a panic
when combined with a particular transform.

This also works around a variety of WebRender bugs that happen when
`mix-blend-mode` is used near the root stacking context.

Signed-off-by: Martin Robinson <mrobinson@abandonedwig.info>

@wpt-pr-bot wpt-pr-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Servo project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants