[opentelemetry-collector]: honor schedulerName in daemonset and statefulset modes#2258
Open
somaz94 wants to merge 1 commit into
Open
Conversation
…atefulset modes Assisted-by: Claude Opus 4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
schedulerNamevalue is documented in values.yaml and wired into the Deployment pod spec, but it was never applied indaemonsetorstatefulsetmode — setting it there had no effect.This mirrors the existing deployment.yaml block into daemonset.yaml and statefulset.yaml so a custom scheduler is honored in all three modes.
Verified with
helm template --set schedulerName=...for each mode (field now renders; absent by default), plusct lintandmake check-examples.