Refactor TLS certificate reference resolver#5439
Merged
salonichf5 merged 4 commits intoJun 16, 2026
Merged
Conversation
salonichf5
approved these changes
Jun 16, 2026
bjee19
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
createExternalReferencesForTLSSecretsResolverininternal/controller/state/graph/gateway_listener.gocarried a//nolint:gocyclodirective and aFIXME(bjee19), called out in #5253 as gocyclo tech debt.Solution: Decompose the listener resolver closure into three focused helpers —
resolveTLSCertRef(single certificate ref resolution),certRefPermitted(ReferenceGrant permission predicate), andapplyCertRefErrors(error aggregation into listener conditions). Behavior is preserved; the//nolint:gocycloandFIXME(bjee19)are removed.This is one slice of #5253 — the issue tracks ~14 such functions, so this PR uses
related:rather thanClosesto avoid auto-closing the umbrella issue.Validation:
golangci-lint run ./internal/controller/state/graph/— 0 issues (gocyclo satisfied)go test ./internal/controller/state/graph/...— passgofmt/go vet/go build— cleanrelated: #5253