Note that Attr.isConnected is always false#44349
Merged
hamishwillee merged 3 commits intoJun 15, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-06-11 23:42:19) |
Contributor
|
@vamshikrishnaramasamy I removed my request for review, and put the reviewer back to "mdn/web" to select a different reviewer from the reviewer pool. In the future, just leave the reviewer, and the system will select a reviewer automatically. |
hamishwillee
reviewed
Jun 9, 2026
hamishwillee
approved these changes
Jun 11, 2026
hamishwillee
left a comment
Collaborator
There was a problem hiding this comment.
Thanks very much @vamshikrishnaramasamy !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42933.
isConnectedalways returnsfalseon an {{domxref("Attr")}} node, even when the attribute'sownerElementis connected to the document. This trips people up, so this adds a note explaining why.As @caugner noted on the issue, this is consistent across Chrome, Firefox, and Safari, and is out of scope for BCD — the spec defines
isConnectedfor all nodes, and since an attribute node has no parent, it has no root that is a document, so it is never "connected".I confirmed the behavior in Chrome: