Skip to content

Remove dead NODE_MODE override param from 2000/5000 node configs#4157

Open
Jefftree wants to merge 1 commit into
kubernetes:masterfrom
Jefftree:remove-dead-node-mode
Open

Remove dead NODE_MODE override param from 2000/5000 node configs#4157
Jefftree wants to merge 1 commit into
kubernetes:masterfrom
Jefftree:remove-dead-node-mode

Conversation

@Jefftree

@Jefftree Jefftree commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Drop the inert NODE_MODE: masterandnondaemons override from 2000_nodes.yaml and 5000_nodes.yaml since nothing reads it (resource_usage.go derives the node set from cluster size, not the param). Orphaned since #1549, which moved that decision to cluster size and dropped the nodeMode template wiring. The files stay in place as they are still referenced via --testoverrides.

Discovered while checking usage for all the flags.

@kubernetes-prow kubernetes-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 23, 2026
@kubernetes-prow kubernetes-prow Bot requested a review from mborsz June 23, 2026 21:49
@kubernetes-prow

kubernetes-prow Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jefftree
Once this PR has been reviewed and has the lgtm label, please assign mborsz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot requested a review from wojtek-t June 23, 2026 21:49
@Jefftree

Jefftree commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

/assign @serathius

@serathius

serathius commented Jun 23, 2026

Copy link
Copy Markdown
Member

Have you checked https://cs.k8s.io/?q=NODE_MODE&i=nope&literal=nope&files=&excludeFiles=&repos= ?

@kubernetes-prow

kubernetes-prow Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@Jefftree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-perf-tests-gce-master-scale-performance-100 5776b5b link true /test pull-perf-tests-gce-master-scale-performance-100
pull-perf-tests-ec2-master-scale-performance-100 5776b5b link true /test pull-perf-tests-ec2-master-scale-performance-100

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Jefftree

Jefftree commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

Have you checked https://cs.k8s.io/?q=NODE_MODE&i=nope&literal=nope&files=&excludeFiles=&repos= ?

It looks like those could all be cleaned up as well.

@Jefftree Jefftree mentioned this pull request Jun 23, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@serathius serathius

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jefftree @serathius