fix(bigtable): populate Value type in _format_execute_query_view_params (#17547)

ad548 · web-flow · commit 8cb77d99103b · 2026-06-24T11:11:06.000-04:00
Ensures that string view parameters construct Value objects with both
string_value and explicit string_type populated.

Fixes issue where view parameters created Value objects missing the
explicit type_ field.
diff --git a/packages/google-cloud-bigtable/google/cloud/bigtable/data/execute_query/_parameters_formatting.py b/packages/google-cloud-bigtable/google/cloud/bigtable/data/execute_query/_parameters_formatting.py
@@ -39,7 +39,7 @@ def _format_execute_query_view_params(
             raise TypeError(
                 f"View parameter {key} must be a string, got {type(value).__name__}"
             )
-        result_values[key] = Value(string_value=value)
+        result_values[key] = _convert_value_to_pb_value_dict(value, SqlType.String())
 
     return result_values
 
diff --git a/packages/google-cloud-bigtable/tests/unit/data/_async/test_client.py b/packages/google-cloud-bigtable/tests/unit/data/_async/test_client.py
@@ -3558,6 +3558,8 @@ async def test_execute_query_with_view_parameters(
         request = execute_query_mock.call_args[0][0]
         assert "user_id" in request.view_parameters
         assert request.view_parameters["user_id"].string_value == "alice"
+        val_type = request.view_parameters["user_id"].type_
+        assert type(val_type).to_dict(val_type) == {"string_type": {}}
 
     @CrossSync.pytest
     async def test_execute_query_with_view_parameters_invalid_type(
diff --git a/packages/google-cloud-bigtable/tests/unit/data/_sync_autogen/test_client.py b/packages/google-cloud-bigtable/tests/unit/data/_sync_autogen/test_client.py
@@ -3019,6 +3019,8 @@ def test_execute_query_with_view_parameters(
         request = execute_query_mock.call_args[0][0]
         assert "user_id" in request.view_parameters
         assert request.view_parameters["user_id"].string_value == "alice"
+        val_type = request.view_parameters["user_id"].type_
+        assert type(val_type).to_dict(val_type) == {"string_type": {}}
 
     def test_execute_query_with_view_parameters_invalid_type(
         self, client, execute_query_mock, prepare_mock

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ def _format_execute_query_view_params(`
`39`	`39`	`raise TypeError(`
`40`	`40`	`f"View parameter {key} must be a string, got {type(value).__name__}"`
`41`	`41`	`)`
`42`		`- result_values[key] = Value(string_value=value)`
	`42`	`+ result_values[key] = _convert_value_to_pb_value_dict(value, SqlType.String())`
`43`	`43`
`44`	`44`	`return result_values`
`45`	`45`