Merging Cmder's `development` branch to `master` branch by DRSDavidSoft · Pull Request #2898 · cmderdev/cmder

DRSDavidSoft · 2023-11-21T00:34:08Z

Summary

This PR merges the current development branch on top of master and brings in the accumulated Cmder work since the last sync.

The biggest themes in this branch are:

Windows Terminal support and related launcher/runtime updates
A refactor of the build/pack scripts around package profiles
Workflow/CI cleanup and consistency fixes
A batch of shell, launcher, and configuration improvements
Documentation and repo hygiene updates

What’s included

Windows Terminal support

This branch adds and refines support for launching Cmder in Windows Terminal, including:

new/default Windows Terminal settings
launcher updates in Cmder.bat and launcher/src/CmderLauncher.cpp
new helper scripts for Git Bash, Mintty, and profile generation
updates to shell integration files like vendor/cmder.sh, vendor/profile.ps1, and vendor/psmodules/Cmder.ps1
support files for Windows Terminal defaults in vendor/windows_terminal_default_settings.json

Build and packaging refactor

The build system has been modernized to use package profiles and shared helpers:

new scripts/package-profiles.json
new helper logic in scripts/utils.ps1
updated scripts/build.ps1, scripts/pack.ps1, and scripts/update.ps1
refreshed examples and documentation in scripts/README.md

This makes the packaging flow more structured and easier to extend.

Workflow and CI updates

The GitHub Actions workflows were cleaned up and aligned with the new scripts:

build workflow updates
tests workflow updates
CodeQL workflow updates
vendor workflow updates
summary formatting and artifact handling improvements

Cmder launcher and runtime improvements

This branch also includes a substantial update to the launcher and core runtime behavior:

launcher project and resource updates
CmderLauncher.cpp changes for the new launch flow
improvements to Cmder.bat
updates to vendor/init.bat, vendor/lib/lib_base.cmd, and vendor/lib/lib_path.cmd
shell startup and environment setup cleanup

Documentation and repo hygiene

A number of documentation and maintenance updates are included as well:

README.md and config/Readme.md adjustments
CHANGELOG.md updates
.gitignore and packignore additions
.git-blame-ignore-revs for cleaner blame history

Notes

This branch is mostly a consolidation of the Windows Terminal work, launcher/runtime improvements, and packaging refactors that have been developed on development.

Verification

The updated workflows were run successfully on development, including:

Build
Tests
CodeQL

Files touched

This merge includes changes across:

GitHub Actions workflows
build and pack scripts
launcher source
Cmder startup and shell integration scripts
Windows Terminal defaults and profile generation
documentation and changelog files

…ws_terminal

Applying the more speed branch to the development

Applying the windows terminal branch to the development

daxgames · 2026-06-15T01:03:52Z

See my last comment in #3090 (comment)

I edited it like 20 times so just want to make sure you see it in its final glory @DRSDavidSoft.

We should continue the discussion here since this pr is actually open.

DRSDavidSoft · 2026-06-19T23:06:44Z

@daxgames Working on it right now with Codex; seems like PowerShell 5.1 doesn't like UTF-8 encoded scripts without BOM while PowerShell 7 allows it. Since both my machine and GitHub actions' infrastructure ran on pwsh v7, adding the emojis didn't cause an issue there. So I'm applying the BOM now, which would hopefully fix the problem and allow the CI/CD to keep the emojis. Sorry for the regression! 😅

Nice diff by the way, how was it generated?

Back to the previous discussion we were having soon 🙏🏻

DRSDavidSoft · 2026-06-19T23:08:17Z

@daxgames thanks for catching this. I reproduced the Windows PowerShell 5.1 failure locally: the emojis themselves are valid, but scripts/utils.ps1 was UTF-8 without BOM, so Windows PowerShell decoded it as the legacy ANSI codepage and the emoji bytes became mojibake that broke parsing.

I pushed a fix in 8155738 that keeps the emojis by making scripts/utils.ps1 UTF-8 with BOM. While testing the build script locally, I also found/fixed a Windows PowerShell 5.1 issue where scripts/build.ps1 default paths based on $PSScriptRoot evaluated too early under powershell.exe -File.

Could you please share:

exactly how you invoked the build script, including shell, command, and working directory
any logs/output from the failing run before your local workaround
what generated the nice side-by-side diff in the screenshot you posted

Comment posted by ChatGPT Codex on behalf of the user (@DRSDavidSoft)

daxgames · 2026-06-19T23:18:31Z

I use delta as my git pager. You can cind it on github. I also use bat as replacemwnt for cat that looks very similar to delta in that it does colored syntax when displaying a file. Both are pretty cool.

As far as the other asks.

I do not have the failed run output handy but if you need it I can get it.

I ran the command ./scripts/build.ps1 -verbose -compile

Shell was Visual Studio 2022 Powershell x64 terminal.

DRSDavidSoft · 2026-06-20T00:02:30Z

@daxgames Thanks dax, I hope the build script is now working correctly as before the regression.

Will switch to the ongoing previous discussion from #3090 (comment) soon; as agreed we'll continue discussion from the old PR here after I fully read and review your excellent points.

Will notify soon 🙏🏻

DRSDavidSoft · 2026-06-20T00:04:44Z

@@ -0,0 +1,163 @@
+@echo off
+
+:: This file was autogenerated by Cmder init.bat


Codex, to make the intent more clear, let's add the word initially like this:

This file was initially autogenerated by Cmder init.bat

DRSDavidSoft · 2026-06-20T00:05:27Z

+:: It is yours to edit and will not be touched again by Cmder.
+::
+:: If you wish to recreate this file simply rename it and Cmder will re-create it the next time it is run
+:: or run the followin command from a Cmder shell:


Codex, please apply typo corrections to "followin" and other possible ones where required

daxgames and others added 30 commits September 25, 2023 11:26

Add initial Windows Terminal support

74c183c

fix

2728f36

Merge branch 'master' into windows_terminal

19fe75c

fix

7db6297

fix

759d0ed

fix

63bab36

fix

7fa041d

add start_git_bash.cmd

7d3e691

Update Cmder command line help

8bb2c5d

add pack code for windows terminal releases

e24f653

Merge branch 'master' of https://github.com/cmderdev/cmder into windo…

cb54352

…ws_terminal

sync and add windows terminal to sources.

ab10e83

Add pack code for windows terminal

ad21915

pack and build all

3671a6e

pack and build all

3cc22ca

pack and build all

58db4e3

turn off /t in windows terminal defaults

01da2fe

PR Review requested changes

ddad83c

PR Review requested changes

43a5e7e

add vendor/bin/create-cmdercfg.cmd

90d86a7

Merge branch 'master' into development

9c834b6

Merge branch 'master' into windows_terminal

678b482

cleanup

2ab6bcd

Merge branch 'master' into more_speed_2

01c41a9

Merge branch 'master' into development

f69e622

properly set CMDER_ROOT for windows terminal bash

86091b7

Merge pull request #2896 from daxgames/more_speed_2

9a40419

Applying the more speed branch to the development

Merge branch 'development' into windows_terminal

8025b5b

Merge pull request #2897 from daxgames/windows_terminal

e01a553

Applying the windows terminal branch to the development

Update Cmder.bat

f0c18f1

DRSDavidSoft commented Jun 14, 2026

View reviewed changes

Comment thread scripts/build.ps1 Outdated

DRSDavidSoft and others added 8 commits June 14, 2026 21:31

Merge branch 'master' into development

3085d90

Normalize casing in PowerShell helpers

2e10a34

Fix casing

9e3e8e4

Restore per-file artifact uploads

cb0df18

Restore per-file artifact links

ece1948

Fix artifact links in build summary

5531447

Add branch metadata to build summary

ff33e02

Add build branch notices

343cb15

DRSDavidSoft added 2 commits June 20, 2026 01:01

Fix vendor PR summary newline

7fd9b3d

Merge remote-tracking branch 'origin/master' into HEAD

1ed09e7

This comment was marked as resolved.

Sign in to view

Merge master into development

4cdd7af

Fix Windows PowerShell build script parsing

8155738

DRSDavidSoft added 2 commits June 20, 2026 02:48

Merge master into development

2a11c30

Address build script review cleanup

471808d

DRSDavidSoft commented Jun 20, 2026

View reviewed changes

DRSDavidSoft added 7 commits June 21, 2026 01:04

Align cmd init naming and generated template

6e277c3

Update tests workflow for init.cmd rename

d34f6b2

Honor nested init guard in generated cmd config

3ff9582

Guard cmd init migration in tests

3c08b7c

Create init.bat compatibility shim

25ee158

Expand development changelog

fea0d2f

Apply PR 3015 script cleanups to development

0d9699d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merging Cmder's `development` branch to `master` branch#2898

Merging Cmder's `development` branch to `master` branch#2898
DRSDavidSoft wants to merge 288 commits into
masterfrom
development

DRSDavidSoft commented Nov 21, 2023 •

edited

Loading

Uh oh!

Uh oh!

daxgames commented Jun 15, 2026 •

edited

Loading

Uh oh!

This comment was marked as resolved.

DRSDavidSoft commented Jun 19, 2026

Uh oh!

DRSDavidSoft commented Jun 19, 2026

Uh oh!

daxgames commented Jun 19, 2026 •

edited

Loading

Uh oh!

DRSDavidSoft commented Jun 20, 2026

Uh oh!

DRSDavidSoft Jun 20, 2026

Uh oh!

DRSDavidSoft Jun 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -0,0 +1,163 @@
		@echo off

		:: This file was autogenerated by Cmder init.bat

Conversation

DRSDavidSoft commented Nov 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What’s included

Windows Terminal support

Build and packaging refactor

Workflow and CI updates

Cmder launcher and runtime improvements

Documentation and repo hygiene

Notes

Verification

Files touched

Uh oh!

Uh oh!

daxgames commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

DRSDavidSoft commented Jun 19, 2026

Uh oh!

DRSDavidSoft commented Jun 19, 2026

Uh oh!

daxgames commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DRSDavidSoft commented Jun 20, 2026

Uh oh!

DRSDavidSoft Jun 20, 2026

Choose a reason for hiding this comment

Uh oh!

DRSDavidSoft Jun 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DRSDavidSoft commented Nov 21, 2023 •

edited

Loading

daxgames commented Jun 15, 2026 •

edited

Loading

daxgames commented Jun 19, 2026 •

edited

Loading